On Mon, Dec 03, 2012 at 08:37:20AM -0500, Josef Bacik wrote: > Btrfs is terrible with O_DIRECT|O_SYNC, mostly because of the constant > waiting. The thing is we have a handy way of waiting for IO that we can > delay to the very last second so we do all of the O_SYNC work and then wait > for a bunch of IO to complete. So introduce a flag to allow the generic > direct io stuff to forgo waiting and leave that up to the file system. > Thanks, I don't really like passing another flag for this, if we we are going to do something like this it should be in a way where: - the actualy waiting code is a helper that btrfs would also use - the main dio code is structured in a way that we have a lower level entry point that skips the waiting, and a higher level one that also calls it. That beeing said I'm not imaginative enough to see how you're actually going to use it. Posting the btrfs side would help with that. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
