On Wed, Nov 21, 2012 at 10:55:24AM +1100, Dave Chinner wrote: > > diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c > > index 2778258..3656b88 100644 > > --- a/fs/xfs/xfs_inode.c > > +++ b/fs/xfs/xfs_inode.c > > @@ -570,11 +570,12 @@ xfs_dinode_from_disk( > > to->di_version = from ->di_version; > > to->di_format = from->di_format; > > to->di_onlink = be16_to_cpu(from->di_onlink); > > - to->di_uid = be32_to_cpu(from->di_uid); > > - to->di_gid = be32_to_cpu(from->di_gid); > > + to->di_uid = make_kuid(&init_user_ns, be32_to_cpu(from->di_uid)); > > + to->di_gid = make_kgid(&init_user_ns, be32_to_cpu(from->di_gid)); > > You can't do this, because the incore inode structure is written > directly to the log. This is effectively an on-disk format change. Yeah, I don't get this either. Over in ocfs2, you do the correct thing, translating at the boundary from ocfs2_dinode to struct inode. Joel -- "I always thought the hardest questions were those I could not answer. Now I know they are the ones I can never ask." - Charlie Watkins http://www.jlbec.org/ jlbec@xxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
