Christoph Hellwig <hch@xxxxxxxxxxxxx> writes: > On Mon, Nov 19, 2012 at 11:41:38PM -0800, Darrick J. Wong wrote: >> Hi, >> >> Fsyncing is tricky business, so factor out the bits of the xfs_file_fsync >> function that can be used from the I/O post-processing path. > > Why would we need to skip the filemap_write_and_wait_range call here? > If we're doing direct I/O we should not have any pages in this regions > anyway. You're also not skipping it in the generic implementation as > far as I can see, so I see no point in doing it just in XFS. OK, I'll fix that. Thanks! Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
