On Mon, Nov 12, 2012 at 04:40:22PM -0800, Andrew Morton wrote: > > > > --- linux-2.6.git.orig/include/linux/fs.h > > +++ linux-2.6.git/include/linux/fs.h > > @@ -1517,6 +1517,8 @@ struct block_device_operations; > > #define HAVE_COMPAT_IOCTL 1 > > #define HAVE_UNLOCKED_IOCTL 1 > > > > +struct seq_file; > > + > > We already have a forward declaration of seq_file in fs.h. At line > 1583(!). > > This is why forward declarations should always be placed at the start > of the file, please. Yes, thanks a lot, Andrew! Cyrill -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html