Re: [PATCH] fs: Fix hang with BSD accounting on frozen filesystem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 07, 2012 at 11:31:39PM +0100, Jan Kara wrote:
> When BSD process accounting is enabled and logs information to a filesystem
> which gets frozen, system easily becomes unusable because each attempt to
> account process information blocks. Thus e.g. every task gets blocked in exit.
> 
> It seems better to drop accounting information (which can already happen when
> filesystem is running out of space) instead of locking system up. This is
> implemented using a special flag FMODE_NO_FREEZE_WAIT in file->f_mode of a
> file to which accounting information is written.

I have no problems with making freeze waiting non-blocking, by why
invent a new flag for what is essentially an O_NONBLOCK operation?

Indeed, if someone opens a file O_NONBLOCK, shouldn't if behave
exactly the same on a frozen filesystem as this special
FMODE_NO_FREEZE_WAIT flag?

FWIW, nfsd could use this as well so that it doesn't block all the
nfsd threads trying to write to a frozen filesystem but instead
returns EJUKEBOX to the client to tell it ot wait for a while before
trying the operation again...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux