On Nov 3, 2012, at 7:27 PM, Alan Cox wrote: >> Your patch is good. But what about returning an error code (for example, -EIO)? Unfortunately, as I can see, the code that call hfsplus_block_free() doesn't analyze return code. I think that it is not good. > > Actually handling the error nicely is a major rework of the file system. > If you want to do that send patches but you'll need to fix up another ton > of places. > Ok. I see. I simply suggest to add in this patch of error code return. I can rework the rest by myself. :-) With the best regards, Vyacheslav Dubeyko. > The patch fixes the crash to the same level of not crashing the rest of > that file system has. > > Alan > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
