2012/10/25 Joel Becker <jlbec@xxxxxxxxxxxx>: > On Tue, Oct 23, 2012 at 02:48:38PM +0200, Marco Stornelli wrote: >> 2012/10/23 Joel Becker <jlbec@xxxxxxxxxxxx>: >> > On Tue, Oct 23, 2012 at 10:58:42AM +0200, Marco Stornelli wrote: >> >> 2012/10/23 Joel Becker <jlbec@xxxxxxxxxxxx>: >> >> > On Sat, Oct 20, 2012 at 02:19:00PM +0200, Marco Stornelli wrote: >> >> >> Removed vmtruncate >> >> >> >> >> >> Signed-off-by: Marco Stornelli <marco.stornelli@xxxxxxxxx> >> >> > >> >> > Acked-by: Joel Becker <jlbec@xxxxxxxxxxxx> >> >> > >> >> > Do you want me to pull this, or are you going to send it with your set? >> >> > >> >> > Joel >> >> > >> >> >> >> I'd prefer to push all via Al's tree since there is a VFS change. >> > >> > SGTM. Thanks! >> > >> > Joel >> > >> >> I've got a doubt and I ask to ocfs2 expert :) It seems i_size_write() >> and truncate_inode_pages() and so on, they are already called in each >> path of setattr for a size change, so maybe we can remove >> truncate_setsize() and simply to remove the vmtuncate code, can you >> give me your opinion? > > Actually, I have to revisit this, because Chrisoph points out > your adjusting i_size outside of a transaction. > > Joel > Actually i_size should be changed in a transaction previous, the code is not changed from this point of view. Indeed the call of truncate_setsize() should be a nop. Marco -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
