On Fri, Oct 05, 2012 at 11:16:12AM -0700, Anatol Pomozov wrote: > Hi, AlViro > > Is any reason why this change is ignored? For me it looks like a > straightforward bugfix. > > A little bit of context for this change. We at Google work on a test > framework that shows how kernel behaves under memory pressure. In the > codepath that I am fixing the syscalls return ENFILE error, but in > fact the correct error would be ENOMEM. get_empty_filp() should > preserve the original error and not to replace all errors with ENFILE. Anatol, I suggest that you rebase this patch against the latest kernel and then resend it; I just tried editing out the angle brackets, and the patch completely failed to apply; every single patch hunk was rejected by patch(1). This may be because when you forwarded the patch as a reply, the whitespace got corrupted --- but that's why I never recommend resending a patch as part of a reply. Instead, send a new patch as a new thread, freshly regenerated against whatever is most likely to be useful to the maintainer (aviro in this case) and then put a ping as a comment or in the subject line. Cheers, - Ted % patch -b -p1 < /tmp/patch patching file arch/ia64/kernel/perfmon.c Hunk #1 FAILED at 2221. 1 out of 1 hunk FAILED -- saving rejects to file arch/ia64/kernel/perfmon.c.rej patching file fs/anon_inodes.c Hunk #1 FAILED at 160. 1 out of 1 hunk FAILED -- saving rejects to file fs/anon_inodes.c.rej patching file fs/file_table.c Hunk #2 FAILED at 108. Hunk #3 FAILED at 117. Hunk #4 FAILED at 149. Hunk #5 FAILED at 173. 4 out of 5 hunks FAILED -- saving rejects to file fs/file_table.c.rej patching file fs/hugetlbfs/inode.c Hunk #1 FAILED at 984. 1 out of 1 hunk FAILED -- saving rejects to file fs/hugetlbfs/inode.c.rej patching file fs/namei.c Hunk #1 FAILED at 2885. 1 out of 1 hunk FAILED -- saving rejects to file fs/namei.c.rej patching file fs/open.c Hunk #1 FAILED at 781. 1 out of 1 hunk FAILED -- saving rejects to file fs/open.c.rej patching file fs/pipe.c Hunk #1 FAILED at 1035. 1 out of 1 hunk FAILED -- saving rejects to file fs/pipe.c.rej patching file ipc/shm.c Hunk #1 FAILED at 1039. 1 out of 1 hunk FAILED -- saving rejects to file ipc/shm.c.rej patching file mm/shmem.c Hunk #1 FAILED at 2948. 1 out of 1 hunk FAILED -- saving rejects to file mm/shmem.c.rej patching file net/socket.c Hunk #1 FAILED at 369. 1 out of 1 hunk FAILED -- saving rejects to file net/socket.c.rej -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
