Re: [PATCH 7/9] fsfreeze: freeze_super and thaw_bdev don't play well together

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2012-10-04 (木) の 10:18 +0200 に Jan Kara さんは書きました:
> > As you say when we get there via the superblock level API
> > it is guaranteed that we have at least one active reference
> > and that MS_BORN is set. However, freeze_bdev() iterates
> > over superblocks using get_active_super() which can return
> > a superblock without the MS_BORN flag set; during sys_mount
> > mount_fs() sets the MS_BORN flag *after* sget() inserts the
> > superblock in all the lists.
> > 
> > If the analysis above is correct we do need the MS_BORN
> > check.
>   Checking again I agree with you. But that seems more like an issue with
> get_active_super() which shouldn't return superblock without MS_BORN.
> Whatever... that can be left for a separate patch.

Yes, let's leave it for a separate patch.

Thanks,
Fernando

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux