Hi, On Sep 17, 2012, at 11:52 PM, Hin-Tak Leung wrote: > Oh, yes, there was a small conflict at the end of super.c when I applied to 3.5.3: > > --------------- > @@ -641,6 +672,7 @@ static void __exit exit_hfsplus_fs(void) > * destroy cache. > */ > rcu_barrier(); > + hfsplus_destroy_attr_tree_cache(); > kmem_cache_destroy(hfsplus_inode_cachep); > } > > ---------------- > > 3.5.3 does not have the "rcu_barrier();" line for whatever reason - since the chunk seem to mean 'put "hfsplus_destroy_attr_tree_cache();" towards the end of __exit exit_hfsplus_fs() just before the last line', that's what I did. > > But as far as I remember that was the only conflict - that does not sound like what you describe though... Did you apply patch set by means of git or patch utility? With the best regards, Vyacheslav Dubeyko. > > Hin-Tak > > --- On Mon, 17/9/12, Vyacheslav Dubeyko <slava@xxxxxxxxxxx> wrote: > >> Hi Hin-Tak, >> >> Now I understand clearly the reason of your issue. This is a >> side effect of not clean patching of your kernel (3.5.3). I >> worked with 3.4.6 kernel during implementation and I didn't >> take into account some changing of hfsplus fs driver in next >> kernel versions during patch set preparation. The 3.5.3 >> kernel has changing in super.c file that can't be merged >> automatically with my patch set. So, if you applied patch >> set by means of git then super.c file was left unchanged. >> But patch for super.c contains very important changing which >> to build attributes tree during file system mount and to >> destroy ones during umount. Thereby, you have warnings about >> failed searching in system log because of absence >> constructed attributes tree in memory. >> >> Currently, I am investigating issue with getting list of >> attributes by means of getfattr. I am going to prepare new >> patch set based under last actual kernel version after issue >> resolving. >> >> With the best regards, >> Vyacheslav Dubeyko. >> >> On Sep 15, 2012, at 8:49 PM, Hin-Tak Leung wrote: >>> -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
