Re: [PATCH 4/4] hfsplus: add support of manipulation by attributes file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

I have merged extended attributes support code into hfsplus fs driver code of 3.5.4 Linux kernel. And I checked working of this code by means of getfattr and setfattr utilities. Really, getfattr doesn't output the list of extended attributes for a file. But I can't see any warnings in system log in my case. Moreover, I can get extended attribute content by name with getfattr and create extended attribute by means of setfattr successfully.

Did you have any troubles during kernel patching or any warnings during kernel compilation? Maybe your issue is a side effect of not proper patching or my patch set is not prepared properly. I am going to make patching of 3.5.3 kernel for checking this presupposition.

Could you try to check working of getting extended attribute by name? The good way for it can be creation of some file, then, creation of simple extended attribute with some name (setfattr) and trying to get content of extended attribute by name (getfattr). It is strange that you see many warnings in your system log. But maybe operation of getting extended attribute by name will end with success. Could you check it on your side?

I used xattr (dev-python/pyxattr) utility during implementation. All operation (create, get, delete) with extended attributes are working successfully on my side. Currently, I found that xattr utility can output full list of file's extended attributes but getfattr can't. I am going to investigate this issue.  

Moreover, maybe extended attributes "com.apple.decmpfs" has some peculiarities. It needs to investigate it. So, I think that it needs to check functionality on simple use case, firstly.

With the best regards,
Vyacheslav Dubeyko.

On Sep 15, 2012, at 8:49 PM, Hin-Tak Leung wrote:

> --- On Sat, 15/9/12, Vyacheslav Dubeyko <slava@xxxxxxxxxxx> wrote:
> 
>> Hi Hin-Tak,
>> 
>> On Sep 15, 2012, at 4:11 AM, Hin-Tak Leung wrote:
>> 
>>> Vyacheslav Dubeyko wrote:
>>>> Hi,
>>>> 
>>>> This patch adds support of manipulation by
>> attributes file.
>>>> 
>>>> With the best regards,
>>>> Vyacheslav Dubeyko.
>>>> --
>>>> From: Vyacheslav Dubeyko <slava@xxxxxxxxxxx>
>>>> Subject: [PATCH 4/4] hfsplus: add support of
>> manipulation by attributes file
>>>> 
>>>> This patch adds support of manipulation by
>> attributes file.
>>>> 
>>>> Reported-by: Hin-Tak Leung <htl10@xxxxxxxxxxxxxxxxxxxxx>
>>>> Signed-off-by: Vyacheslav Dubeyko <slava@xxxxxxxxxxx>
>>> 
>>> NACK. It does not work (i.e. cannot read attributes of
>> files which have them), and also generates a lot of
>> warnings, "hfs: xattr searching failed".
>>> 
>>> The files I looked at are the font suitecase files in
>> the /System/Library/Fonts directory.
>>> 
>> 
>> By the way, do you really confident that any file in your
>> /System/Library/Fonts folder have any extended attribute?
>> 
>> On my Mac none file in /System/Library/Fonts folder has any
>> extended attribute. Could you check presence on extended
>> attributes under Mac OS X by means of `xattr -l` command?
>> 
>> With the best regards,
>> Vyacheslav Dubeyko.
> 
> Sorry, that was a bit brief - I just have access to a Mac OS X 10.7 box from time to time.
> 
> - There are 4 font suitecase files, which shows up to have file size zero under linux, but not on Mac OS X. I formatted the thumb drive under Mac Os X and copied with Finder, but of course it might be something I don't understand in the process.
> 
> - get a lot of "hfs: xattr searching failed" (about 20-ish per command) when I run getfattr on linux.
> 
> - It is a bit confusing apple talking about resource forks and extended attributes as if they are they same thing.
> 
> As an aside, one of the older experients, shows it to a few files with  extended attributes "com.apple.decmpfs". I looked it up, apple use this atttribute to implement per-file compression - hiding the file content compressed in the attribute while having the data fork zero. (different and unrelated to the font issue). This happens on mac os X 10.6 onwards.
> 
> --- On Sat, 15/9/12, Vyacheslav Dubeyko <slava@xxxxxxxxxxx> wrote:
> 
>> Hi,
>> 
>> On Sep 15, 2012, at 4:11 AM, Hin-Tak Leung wrote:
>> 
>>> Vyacheslav Dubeyko wrote:
>>>> Hi,
>>>> 
>>>> This patch adds support of manipulation by
>> attributes file.
>>>> 
>>>> With the best regards,
>>>> Vyacheslav Dubeyko.
>>>> --
>>>> From: Vyacheslav Dubeyko <slava@xxxxxxxxxxx>
>>>> Subject: [PATCH 4/4] hfsplus: add support of
>> manipulation by attributes file
>>>> 
>>>> This patch adds support of manipulation by
>> attributes file.
>>>> 
>>>> Reported-by: Hin-Tak Leung <htl10@xxxxxxxxxxxxxxxxxxxxx>
>>>> Signed-off-by: Vyacheslav Dubeyko <slava@xxxxxxxxxxx>
>>> 
>>> NACK. It does not work (i.e. cannot read attributes of
>> files which have them), and also generates a lot of
>> warnings, "hfs: xattr searching failed".
>>> 
>>> The files I looked at are the font suitecase files in
>> the /System/Library/Fonts directory.
>> 
>> 
>> Could you share kernel version that you are using?
>> 
>> What utility do you use for getting of extended attributes
>> list? I need more details for issue reproduction.
>> 
>> Could you share some more detailed output of system log
>> related to the issue?
> 
> I patched over 3.5.3 with just the 4 patches.
> 
> I also have some messy scripts based on work from the iphone hackery people to look at details at the low-level.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux