On Sat 08-09-12 23:49:00, Wang Sheng-Hui wrote: > The function scans @delaying_queue and stops at the first inode > whose dirtied_when is after *work->older_than_this. So the expired > ones being moved are those before *work->older_than_this. Correct > the comment here. Fengguang Wu would be a more appropriate for this. Added to CC. BTW the patch is fine so feel free to add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza > > Signed-off-by: Wang Sheng-Hui <shhuiw@xxxxxxxxx> > --- > fs/fs-writeback.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > index be3efc4..fd255c0 100644 > --- a/fs/fs-writeback.c > +++ b/fs/fs-writeback.c > @@ -248,7 +248,7 @@ static bool inode_dirtied_after(struct inode *inode, unsigned long t) > } > > /* > - * Move expired (dirtied after work->older_than_this) dirty inodes from > + * Move expired (dirtied before work->older_than_this) dirty inodes from > * @delaying_queue to @dispatch_queue. > */ > static int move_expired_inodes(struct list_head *delaying_queue, > -- > 1.7.1 > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
