On 09/07/2012 01:48 PM, Jeff Layton wrote:
On Fri, 7 Sep 2012 08:34:53 -0400 Jeff Layton<jlayton@xxxxxxxxxx> wrote:Signed-off-by: Jeff Layton<jlayton@xxxxxxxxxx> --- fs/proc/base.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/proc/base.c b/fs/proc/base.c index 1b6c84c..58e801b 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -2758,7 +2758,8 @@ static void *proc_self_follow_link(struct dentry *dentry, struct nameidata *nd) pid_t tgid = task_tgid_nr_ns(current, ns); char *name = ERR_PTR(-ENOENT); if (tgid) { - name = __getname(); + /* 10 for max length of an int in decimal + NULL terminator */ + name = kmalloc(11, GFP_KERNEL);^^^^^ Bah...my mistake. This should be "12", since it's possible (though unlikely) that this value could be negative. Is there a better way to express "strlen of max representation of an int in decimal" ?
See INT_BUFSIZE_BOUND() in: http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=blob;f=lib/intprops.h;hb=HEAD cheers, Pádraig. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
