On Sun, Aug 26, 2012 at 04:05:20PM +0100, Al Viro wrote: > > Applied, with a couple of changes: > * there's no need for those games with ihold/iput - opened file pins > its inode down just fine, TYVM. Ah, yeah, thanks! > * struct fd_info is pointless in that form - the last argument > of single_open() will end up in seq_file ->private, so let's just pass > the inode there and use m->private in ->show(). Yes. Thanks! > I'll push that into vfs.git#master (along with the previous patch) in a few hours. > > O_CLOEXEC is taken care of in my tree. FWIW, I'm consolidating descriptor > handling in general into fs/file.c (and I'm seriously tempted to rename > that sucker to something like fs/descriptors.c or fs/fdtable.c); some of > that stuff is already in #master. I'm probably going to move some of the > code from your fs/proc/fd.c there as well... OK, so I'll fetch your tree and rebase the rest of series on top then, to continue fdinfo handling. Sounds good? -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html