On Sat, Aug 25, 2012 at 06:16:05PM +0100, Al Viro wrote: > On Thu, Aug 23, 2012 at 02:43:24PM +0400, Cyrill Gorcunov wrote: > > This patch prepares the ground for further extension of > > /proc/pid/fd[info] handling code by moving fdinfo handling > > code into fs/proc/fd.c. > > > > I think such move makes both fs/proc/base.c and fs/proc/fd.c > > easier to read. > > BTW, looking at the other stuff in fs/proc/base.c, why the hell is > struct file * grabbed in proc_map_files_readdir()? All we do with > it is passing it to proc_fill_cache(), which passes it to > proc_map_files_instantiate(), which looks at two sodding bits > in file->f_mode. Then we go and fput() all those struct file > references we'd been putting into the array... What for? Well, this could be simplified indeed, if I understand you correctly you propose just save f_mode in flexible array and use it instead of struct file, right? (which will require to rewrite code a bit) Cyrill -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
