On Fri, Aug 10, 2012 at 1:26 AM, Alex Kelly <alex.page.kelly@xxxxxxxxx> wrote: > This prepares for making core dump functionality optional. > > The variable "suid_dumpable" and associated functions are left in fs/exec.c > because they're used elsewhere, such as in ptrace. > > Signed-off-by: Alex Kelly <alex.page.kelly@xxxxxxxxx> > Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx> > --- > v2: This patch set is a second revision that follows some suggestions from > Ingo Molnar and Josh Triplett. Specifically, authorship of commits is > revised for consistency, and an additional two patches cleaning up artifacts > and making headers more sane are added. > > v3: This version fixes a few more authorship issues and some problems caused > by a bad git send-email config. Sorry about the extra mails > > v4: This version fixes some ordering issues pointed out by Kees Cook and Josh > Triplett, such that the order of the functions moved to fs/coredump.c is now > consistent with their original order in fs/exec.c. v4 also drops some extra > blank lines unintentionally introduced in fs/coredump.c, to avoid the need to > clean them up later. That left the cleanup patch just reformatting a comment, > so I dropped that patch. Some of the functions moved to coredump.c need a lot > of cleaning up, but I'm not sure that those formatting changes should be > folded into this patch series. Thanks for the cleanups! This looks great now. For all three patches: Acked-by: Kees Cook <keescook@xxxxxxxxxxxx> -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
