Re: [3.6-rc1] fs: bad unlock balance warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 04, 2012 at 12:21:43PM +0900, Tetsuo Handa wrote:
> Hello.
> 
> Bisection with an error injection
> 
> --- a/security/security.c
> +++ b/security/security.c
> @@ -747,6 +747,10 @@ int security_file_open(struct file *file, const struct cred *cred)
>  {
>         int ret;
> 
> +       if (ACC_MODE(file->f_flags) == FMODE_WRITE &&
> +           current->pid == 1)
> +               return -EPERM;
> +
>         ret = security_ops->file_open(file, cred);
>         if (ret)
>                 return ret;
> 
> reported that commit eb04c282
> "fs: Add freezing handling to mnt_want_write() / mnt_drop_write()"
> is causing this warning.
> 
> Would you check?

That's missed mnt_drop_write() in cleanup_all: side of do_dentry_open().  I've thrown a fix
in #for-linus; check if it works for you...
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux