Hi, On Jul 20, 2012, at 3:56 AM, Hin-Tak Leung wrote: > After a whole year, I am revisiting the HFS+ journalling work from last summer - rebasing it to 3.4.4 (current-ish production-use kernel), a couple of patches from Matthew Garrett which clean up all the ifdefs CONFIG_HFSPLUS_JOURNAL and makes the code far more readable; and actually have a disk I don't mind trashing, formatted with two HFS+ journalled partition (one case-sensitive, one not) to try writing, deleting. At a minimum, I am hoping that normal usage should work: i.e. partitions which are unmounted cleanly should pass 100% for fsck.hfsplus (port of apple's official diskdev_cmds). We are not yet talking about unplugging a disk in the middle of a write/sync yet. The result is rather surprising: > > - I found that delete/unlink from linux almost always results in fsck.hfsplus complaining about unused nodes not being zero'ed, and needing minor repair. So this is somewhat expected - the typical linux design for performance, and not doing more than necessary; but this also indicates a somewhat significant difference in behavior with HFS+ under Mac OS X - Mac OS X probably zero's deleted/unlinked data nodes, maybe for security reasons. Should this be changed in the linux driver for hfsplus? Just to make fsck.hfsplus happy? > > - I also found that deleting/unlinking Mac-generated files from linux results in complaints about inconsistent counts of extended attributes and catalog files. This is again not surprising - some of Mac OS X's file attributes have no linux equivalents, and are stored elsewhere anyway. But one might want to try to look up and clean up those associated extended attributes. This is a bug. As I can understand, you report about found bugs. Am I correct? Could you please describe these bugs with reproduction path and error output of fsck.hfsplus? > Neither of these are specific to journalling support - just problems with hfsplus that have always been there for years. The good news is that read/write to journalled HFS+ from linux is okay - just do not try to delete, and especially files which were not created by linux in the first place. (i.e. write from Mac and delete/move in linux is bad). > > I also just found that since last summer, Netgear had released a few updated tar balls for the GPL part of their network storage appliances (from which the HFS+ journalling support came from). I downloaded the new tar balls but haven't looked at what changed yet, and will do so in due course. > > Perhaps this is a question for the file system maintainer: how strict is one in enforcing the 80-character line length and no-multi-line-string warning? there are a lot of long debug messages in the netgear code. > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html With the best regards, Vyacheslav Dubeyko. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
