Hi Jan, Dave, (2012/07/13 21:59), Jan Kara wrote:
On Thu 12-07-12 18:02:07, Fernando Luis Vázquez Cao wrote:The thawing of a filesystem through sysrq-j loops infinitely as it incorrectly detects a thawed filesytsem as frozen and tries to unfreeze repeatedly. This is a regression caused by 4504230a71566785a05d3e6b53fa1ee071b864eb ("freeze_bdev: grab active reference to frozen superblocks") in that it no longer returned -EINVAL for superblocks that were not frozen. Return -EINVAL when the filesystem is already unfrozen to avoid this problem. Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx> Cc: Jan Kara <jack@xxxxxxx> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> Signed-off-by: Fernando Luis Vazquez Cao <fernando@xxxxxxxxxxxxx>Looks good. You can add: Reviewed-by: Jan Kara <jack@xxxxxxx>
Jan, thank you for the detailed review of the patch set. I really appreciate it. This week I am pretty busy with other stuff so I may not be able to address your comments and Dave's until next Monday. Regards, Fernando -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
