Yuanhan Liu <yuanhan.liu@xxxxxxxxxxxxxxx> writes: > The only case that nr_pages will be < 0 is that nr_pages overflowed due > to nr_events is too big. But it is exclued at ioctx_alloc(). Right, the number of events is limited to what will fit in 256MB, for some odd reason. Maybe Ben can comment on that. > Thus, nr_pages will always > 0. So remove the dead 'if (nr_pages < 0)' > code block. Sure, but I don't see any harm in keeping this check. We do add another page to the size, so retesting for overflow is good practice, and isn't going to kill performance. So, I'm going to NAK this. Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
