On 2012/07/04 20:14, Christoph Hellwig wrote:
On Wed, Jul 04, 2012 at 06:52:31PM +0900, Fernando Luis Vazquez Cao wrote:
Subject: NTFS: remove references to long gone super operations
From: Fernando Luis Vazquez Cao <fernando@xxxxxxxxxxxxx>
->delete_inode(), ->write_super_lockfs(), ->unlockfs() are gone so remove
refereces to them in the NTFS code. Noticed while cleaning up the fsfreeze
mess.
How about removing all the long comments about unimplemented operations?
No major filesystem does this and there's no real point either.
Good point. Updated patch attached.
Subject: NTFS: remove references to long gone super operations and unimplemented methods
From: Fernando Luis Vazquez Cao <fernando@xxxxxxxxxxxxx>
->delete_inode(), ->write_super_lockfs(), ->unlockfs() are gone so remove
refereces to them in the NTFS code. Remove unnecessary comments about
unimplemented methods while at it (suggested by Christoph Hellwig).
Noticed while cleaning up the fsfreeze mess.
Signed-off-by: Fernando Luis Vazquez Cao <fernando@xxxxxxxxxxxxx>
---
diff -urNp linux-3.5-rc5-orig/fs/ntfs/super.c linux-3.5-rc5/fs/ntfs/super.c
--- linux-3.5-rc5-orig/fs/ntfs/super.c 2012-05-21 07:29:13.000000000 +0900
+++ linux-3.5-rc5/fs/ntfs/super.c 2012-07-04 20:33:30.528946289 +0900
@@ -2660,31 +2660,14 @@ static const struct super_operations ntf
.alloc_inode = ntfs_alloc_big_inode, /* VFS: Allocate new inode. */
.destroy_inode = ntfs_destroy_big_inode, /* VFS: Deallocate inode. */
#ifdef NTFS_RW
- //.dirty_inode = NULL, /* VFS: Called from
- // __mark_inode_dirty(). */
.write_inode = ntfs_write_inode, /* VFS: Write dirty inode to
disk. */
- //.drop_inode = NULL, /* VFS: Called just after the
- // inode reference count has
- // been decreased to zero.
- // NOTE: The inode lock is
- // held. See fs/inode.c::
- // generic_drop_inode(). */
- //.delete_inode = NULL, /* VFS: Delete inode from disk.
- // Called when i_count becomes
- // 0 and i_nlink is also 0. */
- //.write_super = NULL, /* Flush dirty super block to
- // disk. */
- //.sync_fs = NULL, /* ? */
- //.write_super_lockfs = NULL, /* ? */
- //.unlockfs = NULL, /* ? */
#endif /* NTFS_RW */
.put_super = ntfs_put_super, /* Syscall: umount. */
.statfs = ntfs_statfs, /* Syscall: statfs */
.remount_fs = ntfs_remount, /* Syscall: mount -o remount. */
.evict_inode = ntfs_evict_big_inode, /* VFS: Called when an inode is
removed from memory. */
- //.umount_begin = NULL, /* Forced umount. */
.show_options = ntfs_show_options, /* Show mount options in
proc. */
};
