On Fri, Jun 22, 2012 at 7:21 AM, Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote: > Kees Cook <keescook@xxxxxxxxxxxx> writes: > >> This patch introduces suid_dumpable=3 to allow privilege-changed processes >> to be dumped only to a pipe handler (and not directly to disk). The value >> of suid_dumpable=2 is now deprecated, and attempting to set this sysctl >> value returns -EINVAL. > > Your patch descriptoin is wrong. Deprecate means something is encouraged > not to be used not that the functionality is removed. I think what > you are trying to say is that the value suid_dumpable=2 is now historic. > > Your implementation is absolutely gross. Reading the value from > twice from user space?? Is an if statement that hard to code? I will rework this and resend. -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html