Re: [PATCH 00/21] vfs: atomic open v6 (part 2)

[Miklos Szeredi <miklos@xxxxxxxxxx>]

I don't like this:

    make ->atomic_open() return int
    
    Change of calling conventions:
    old         new
    NULL                1
    file                0
    ERR_PTR(-ve)        -ve
    
    Caller *knows* that struct file *; no need to return it.

Yes, ordinary filesystems the caller knows the 'struct file *' but for
overlayfs (and stacking in general) wants to be able to return a file
obtained by opening the file on another filesystem.

Thanks,
Miklos

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html