On Sat 02-06-12 22:40:08, Akinobu Mita wrote:
> Use memweight() to count the total number of bits clear in memory area.
>
> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> Cc: linux-fsdevel@xxxxxxxxxxxxxxx
> ---
>
> No changes from v1
>
> fs/minix/bitmap.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/minix/bitmap.c b/fs/minix/bitmap.c
> index 4bc50da..564f1a5 100644
> --- a/fs/minix/bitmap.c
> +++ b/fs/minix/bitmap.c
> @@ -29,10 +29,8 @@ static __u32 count_free(struct buffer_head *map[], unsigned blocksize, __u32 num
> unsigned blocks = DIV_ROUND_UP(numbits, blocksize * 8);
>
> while (blocks--) {
> - unsigned words = blocksize / 2;
> - __u16 *p = (__u16 *)(*map++)->b_data;
> - while (words--)
> - sum += 16 - hweight16(*p++);
> + sum += blocksize * BITS_PER_BYTE -
> + memweight((*map++)->b_data, blocksize);
Hmm, just using bitmap_weight() should be fine here as well AFAICS...
Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
