Hi Fengguang, Looks we should call INIT_WORK_ONSTACK() to suppress this warning, it was gone away with below fix. Thanks, -Jeff Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx> --- fs/xfs/xfs_alloc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/xfs/xfs_alloc.c b/fs/xfs/xfs_alloc.c index 0f0df27..0be396d 100644 --- a/fs/xfs/xfs_alloc.c +++ b/fs/xfs/xfs_alloc.c @@ -2443,7 +2443,7 @@ xfs_alloc_vextent( DECLARE_COMPLETION_ONSTACK(done); args->done = &done; - INIT_WORK(&args->work, xfs_alloc_vextent_worker); + INIT_WORK_ONSTACK(&args->work, xfs_alloc_vextent_worker); queue_work(xfs_alloc_wq, &args->work); wait_for_completion(&done); return args->result; -- 1.7.9 On 06/03/2012 08:51 PM, Fengguang Wu wrote: > Hello, > > I got this warning when turning on object debugging: > > [ 780.529603] XFS (vdd): Ending clean mount > [ 781.454590] ODEBUG: object is on stack, but not annotated > [ 781.455433] ------------[ cut here ]------------ > [ 781.455433] WARNING: at /c/kernel-tests/sound/lib/debugobjects.c:301 __debug_object_init+0x173/0x1f1() > [ 781.455433] Hardware name: Bochs > [ 781.455433] Modules linked in: > [ 781.455433] Pid: 26910, comm: kworker/0:2 Not tainted 3.4.0+ #51 > [ 781.455433] Call Trace: > [ 781.455433] [<ffffffff8106bc84>] warn_slowpath_common+0x83/0x9b > [ 781.455433] [<ffffffff8106bcb6>] warn_slowpath_null+0x1a/0x1c > [ 781.455433] [<ffffffff814919a5>] __debug_object_init+0x173/0x1f1 > [ 781.455433] [<ffffffff81491c65>] debug_object_init+0x14/0x16 > [ 781.455433] [<ffffffff8108842a>] __init_work+0x20/0x22 > [ 781.455433] [<ffffffff8134ea56>] xfs_alloc_vextent+0x6c/0xd5 > [ 781.455433] [<ffffffff8135968b>] xfs_bmap_btalloc+0x504/0x7b0 > [ 781.455433] [<ffffffff81ac0e47>] ? _raw_spin_unlock+0x29/0x3d > [ 781.455433] [<ffffffff81384257>] ? xfs_iext_bno_to_ext+0xa8/0x128 > [ 781.455433] [<ffffffff81367550>] ? xfs_bmbt_get_all+0x18/0x1a > [ 781.455433] [<ffffffff8135a55d>] ? xfs_bmap_search_multi_extents+0x9e/0xe2 > [ 781.455433] [<ffffffff81365839>] xfs_bmapi_allocate+0x129/0x2d6 > [ 781.455433] [<ffffffff813491fe>] ? kmem_zone_alloc+0x63/0xaf > [ 781.455433] [<ffffffff81365e39>] xfs_bmapi_write+0x453/0x8cd > [ 781.455433] [<ffffffff813491fe>] ? kmem_zone_alloc+0x63/0xaf > [ 781.455433] [<ffffffff8133d8a4>] xfs_iomap_write_allocate+0x1c4/0x2c5 > [ 781.455433] [<ffffffff8132d773>] xfs_map_blocks+0x1a6/0x418 > [ 781.455433] [<ffffffff8132e73b>] xfs_vm_writepage+0x329/0x558 > [ 781.455433] [<ffffffff81137c9c>] __writepage+0x17/0x36 > [ 781.455433] [<ffffffff811379f0>] write_cache_pages+0x305/0x451 > [ 781.455433] [<ffffffff81137c85>] ? bdi_set_max_ratio+0x6f/0x6f > [ 781.455433] [<ffffffff8132cab8>] ? xfs_vm_writepages+0x2c/0x51 > [ 781.455433] [<ffffffff810c465f>] ? __lock_acquired+0x3a/0x29e > [ 781.455433] [<ffffffff81137b7f>] generic_writepages+0x43/0x59 > [ 781.455433] [<ffffffff8132cad2>] xfs_vm_writepages+0x46/0x51 > [ 781.455433] [<ffffffff81138cca>] do_writepages+0x23/0x2c > [ 781.455433] [<ffffffff8112f785>] __filemap_fdatawrite_range+0x53/0x55 > [ 781.455433] [<ffffffff8113002e>] filemap_fdatawrite_range+0x13/0x15 > [ 781.455433] [<ffffffff81339177>] xfs_flush_pages+0x6d/0xa2 > [ 781.455433] [<ffffffff81343146>] xfs_sync_inode_data+0x70/0x8b > [ 781.455433] [<ffffffff8134370e>] xfs_inode_ag_walk+0x29f/0x452 > [ 781.455433] [<ffffffff813434d0>] ? xfs_inode_ag_walk+0x61/0x452 > [ 781.455433] [<ffffffff810a592e>] ? cpuacct_charge+0x27/0x1de > [ 781.455433] [<ffffffff813430d6>] ? xfs_sync_worker+0x8c/0x8c > [ 781.455433] [<ffffffff8138ce64>] ? xfs_uuid_unmount+0xbb/0xbb > [ 781.455433] [<ffffffff8138ce64>] ? xfs_uuid_unmount+0xbb/0xbb > [ 781.455433] [<ffffffff8147a64e>] ? radix_tree_lookup_element+0xc5/0x129 > [ 781.455433] [<ffffffff8138cf8a>] ? xfs_perag_get+0x126/0x225 > [ 781.455433] [<ffffffff8138ce64>] ? xfs_uuid_unmount+0xbb/0xbb > [ 781.455433] [<ffffffff81343925>] ? xfs_inode_ag_iterator+0x64/0x8b > [ 781.455433] [<ffffffff813430d6>] ? xfs_sync_worker+0x8c/0x8c > [ 781.455433] [<ffffffff813438fd>] xfs_inode_ag_iterator+0x3c/0x8b > [ 781.455433] [<ffffffff8134398e>] xfs_sync_data+0x42/0x63 > [ 781.455433] [<ffffffff813439cf>] xfs_flush_worker+0x20/0x32 > [ 781.455433] [<ffffffff8108a00e>] process_one_work+0x2ea/0x593 > [ 781.455433] [<ffffffff81089ee3>] ? process_one_work+0x1bf/0x593 > [ 781.455433] [<ffffffff810c465f>] ? __lock_acquired+0x3a/0x29e > [ 781.455433] [<ffffffff813439af>] ? xfs_sync_data+0x63/0x63 > [ 781.455433] [<ffffffff8108a2d8>] process_scheduled_works+0x21/0x2f > [ 781.455433] [<ffffffff8108af23>] worker_thread+0x12b/0x1d2 > [ 781.455433] [<ffffffff8108adf8>] ? manage_workers.isra.20+0xab/0xab > [ 781.455433] [<ffffffff810922f8>] kthread+0x9a/0xa2 > [ 781.455433] [<ffffffff81aca074>] kernel_thread_helper+0x4/0x10 > [ 781.455433] [<ffffffff81ac0eee>] ? _raw_spin_unlock_irq+0x2e/0x48 > [ 781.455433] [<ffffffff810c8130>] ? trace_hardirqs_on+0xd/0xf > [ 781.455433] [<ffffffff81ac13f0>] ? retint_restore_args+0x13/0x13 > [ 781.455433] [<ffffffff8109225e>] ? __init_kthread_worker+0x5a/0x5a > [ 781.455433] [<ffffffff81aca070>] ? gs_change+0x13/0x13 > [ 781.455433] ---[ end trace 501ea1b14d9cfbec ]--- > > Thanks, > Fengguang > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
