On Fri, May 18, 2012 at 09:30:18AM -0700, Tejun Heo wrote:
> On Thu, May 17, 2012 at 10:59:56PM -0400, koverstreet@xxxxxxxxxx wrote:
> > From: Kent Overstreet <koverstreet@xxxxxxxxxx>
> >
> > This is for the new bio splitting code. When we split a bio, if the
> > split occured on a bvec boundry we reuse the bvec for the new bio. But
> > that means bio_free() can't free it, hence the explicit flag.
> >
> > Signed-off-by: Kent Overstreet <koverstreet@xxxxxxxxxx>
> > ---
> > fs/bio.c | 3 ++-
> > include/linux/blk_types.h | 1 +
> > 2 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/fs/bio.c b/fs/bio.c
> > index ecc9088..3332800 100644
> > --- a/fs/bio.c
> > +++ b/fs/bio.c
> > @@ -234,7 +234,7 @@ void bio_free(struct bio *bio, struct bio_set *bs)
> > {
> > void *p;
> >
> > - if (bio_has_allocated_vec(bio))
> > + if (bio_flagged(bio, BIO_HAS_VEC))
> > bvec_free_bs(bs, bio->bi_io_vec, BIO_POOL_IDX(bio));
>
> We can remove bio_has_allocated_vec()?
Yep! Adding that to the patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
