On 16.05.2012 16:34, Jan Kara wrote: > On Wed 16-05-12 01:10:22, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> I also have a counterpart for mkudffs/udf-tools but sourceforge homepage >> seems to be abandoned does anybody know if there is a new homepage for >> mkudffs? > Thanks for the patch! You're welcome. Thanks for reviewing. It looks OK but shouldn't we rather use the helper > functions you introduced in the NLS code? It look wrong to replicate > decoding of UTF16 here. > The helper functions are limited to buffers aligned on 16-bit boundary which is not the case of this buffer. I see following solutions: 0) Homegrown like in previous patch 1) Add a new "endianness" UTF16_LITTLE_ENDIAN_UNALIGNED 2) Split code for "compressed" vs "uncompressed" and copy the string to a temporary buffer in "uncompressed" branch. 3) Like 2 but make buffer sliding and contain only 2 elements. I think 1 or 3 would be the most reasonable. Which solution do you prefer? -- Regards Vladimir 'φ-coder/phcoder' Serbinenko
Attachment:
signature.asc
Description: OpenPGP digital signature
