On Fri, Apr 27, 2012 at 11:21:04AM -0500, Eric Sandeen wrote: > As far as I know, this does not fix any bugs - nfs in the kernel > doesn't use SEEK_END, and I don't know of any user who does. But > some ext4 folks seem keen on doing the right thing here, and I can't > really argue. I like it. In particular it removes a lot of calls to i_size_read() which may have some nice benefits on 32-bit systems. However, there is only one call to generic_file_llseek_size() in the kernel (and it's in ext4!) I would suggest simply changing the prototype of generic_file_llseek_size ... or if you insist, just renaming it to generic_file_llseek_size_eof(). -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
