On Tue, Mar 06, 2012 at 12:48:28PM -0800, Darrick J. Wong wrote: > diff --git a/fs/ext4/ext4_jbd2.c b/fs/ext4/ext4_jbd2.c > index aca1790..90f7c2e 100644 > --- a/fs/ext4/ext4_jbd2.c > +++ b/fs/ext4/ext4_jbd2.c > @@ -138,16 +138,23 @@ int __ext4_handle_dirty_metadata(const char *where, unsigned int line, > } > > int __ext4_handle_dirty_super(const char *where, unsigned int line, > - handle_t *handle, struct super_block *sb) > + handle_t *handle, struct super_block *sb, > + int now) > { > struct buffer_head *bh = EXT4_SB(sb)->s_sbh; > int err = 0; > > if (ext4_handle_valid(handle)) { > + ext4_superblock_csum_set(sb, > + (struct ext4_super_block *)bh->b_data); > err = jbd2_journal_dirty_metadata(handle, bh); > if (err) > ext4_journal_abort_handle(where, line, __func__, > bh, handle, err); > + } else if (now) { > + ext4_superblock_csum_set(sb, > + (struct ext4_super_block *)bh->b_data); > + mark_buffer_dirty(bh); > } else > sb->s_dirt = 1; > return err; What's the point of having the ext4_handle_dirty_super_now() variant? I don't see the point of having this? - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html