At present "error" is set irrespective of do_filp_open failed or not.
Setting error to PTR_ERR(file) on do_filp_open failure only.
Signed-off-by: Sasikanth V <sasikanth.v19@xxxxxxxxx>
---
fs/exec.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/exec.c b/fs/exec.c
index b1fd202..cb43367 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -129,9 +129,10 @@ SYSCALL_DEFINE1(uselib, const char __user *, library)
file = do_filp_open(AT_FDCWD, tmp, &uselib_flags, LOOKUP_FOLLOW);
putname(tmp);
- error = PTR_ERR(file);
- if (IS_ERR(file))
+ if (IS_ERR(file)) {
+ error = PTR_ERR(file);
goto out;
+ }
error = -EINVAL;
if (!S_ISREG(file->f_path.dentry->d_inode->i_mode))
--
1.7.3.4
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
