On Wed, Feb 15, 2012 at 01:45:27AM +0300, Alexey Dobriyan wrote: > 1) consistently use "unsigned int" for dentry name length, > 2) reuse subtraction result for return value, exact value doesn't matter > because function is only used in boolean context, > 3) use *p++ idiom for even better code. > > All of this results in performance speedup of "git diff" > which is way out of statistical error (0.4% vs 0.15% of 3 sigma): Would you have any interest to port this patch on top of Linus' latest changes there? 0.4% increase is nothing to sneeze at. There may be some improvements with the DCACHE_WORD_ACCESS code too. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html