On Wed 11-04-12 11:45:31, Vivek Goyal wrote: > On Wed, Apr 11, 2012 at 11:40:05AM -0400, Vivek Goyal wrote: > > On Wed, Apr 11, 2012 at 12:24:25AM +0200, Jan Kara wrote: > > > > [..] > > > > I have implemented and posted patches for per bdi per cgroup congestion > > > > flag. The only problem I see with that is that a group might be congested > > > > for a long time because of lots of other IO happening (say direct IO) and > > > > if you keep on backing off and never submit the metadata IO (transaction), > > > > you get starved. And if you go ahead and submit IO in a congested group, > > > > we are back to serialization issue. > > > Clearly, we mustn't throttle metadata IO once it gets to the block layer. > > > That's why we discuss throttling of processes at transaction start after > > > all. But I agree starvation is an issue - I originally thought blk-throttle > > > throttles synchronously which wouldn't have starvation issues. > > Current bio throttling is asynchrounous. Process can submit the bio > and go back and wait for bio to finish. That bio will be queued at device > queue in a per cgroup queue and will be dispatched to device according > to configured IO rate for cgroup. > > The additional feature for buffered throttle (which never went upstream), > was synchronous in nature. That is we were actively putting writer to > sleep on a per cgroup wait queue in the request queue and wake it up when > it can do further IO based on cgroup limits. Hmm, but then there would be similar starvation issues as with my simple scheme because async IO could always use the whole available bandwidth. Mixing of sync & async throttling is really problematic... I'm wondering how useful the async throttling is. Because we will block on request allocation once there are more than nr_requests pending requests so at that point throttling becomes sync anyway. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
