Re: key/value-pairs for improved printk()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Apr 7, 2012 at 01:58, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Apr 06, 2012 at 10:23:08PM +0200, Dan Luedtke wrote:
>
>> To throw something in the ring, I suggest we append all printk() after
>> mounting (e.g. fill_super when autodetecting a fs) with key/value pairs
>> like
>>   filesystem=mycoolfs

Filesystem types can be reliably derived from the major:minor of the
superblock, even for non-device-backed mounts. I don't think that is
needed. A "DEVICE=b0:27" would be enough for most, if not all, use
cases.

>>   device=sda1

The time of assuming single-device mounts and filesystems should be
over. I don't think any new stuff should appear that way in any
export, especially not with the textual device name, when we have
reliably working dev_t numbers already.

>>   success=true

Not sure if that's really useful, we either mounted it or we didn't.
And how would a failure look like success=failed-with-error-7.

>> I hope this gets the discussion started!
>
> You've missed the all-important
>    bikeshed_colour=

That sounds useful, and it's nicely machine-readable. It think it
should be all uppercase, and to avoid localization problems we should
assign every color a UUID so that it looks like:
"BIKESHED_COLOR=fae73a2d-0a20-4b70-bd5a-7e9af2894508 :)".

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux