On Mon, 2012-04-02 at 16:48 +0200, Joel Reardon wrote: > > > > You support only one length - please, kill ivlen parameter. > > > > Also, should ubifs_aes_crypt be static? I do not see any users outside > > of compress.c. In this case remove the "ubifs_" prefix. But a > > non-written convention, in UBIFS we _tend_ to prefix only non-static > > functions with "ubifs_" and avoid having it for static functions. > > > > Should length for key remain, and the IV is just the same? Or should the > global #define just be used inside the aes function. I guess I was a little confused WRT iv vs cryptokey. Anyway, I thought you just use UBIFS_CRYPTO_KEYSIZE for all of this, why not to just use the constant in this function? Why passing the length as an argument? -- Best Regards, Artem Bityutskiy
Attachment:
signature.asc
Description: This is a digitally signed message part
