On Sat, Mar 31, 2012 at 12:39 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > > Variants: > 1) drop that commit, fold obvious fix into it, leave it for for-next > once -rc1 is there; ask you to pull the branch with that sucker excluded > 2) fold the fix into commit, ask you to pull the resulting branch > 3) add fix to the end of existing branch, ask to pull Let's go for (2). I'll take a new look after the pull request, but no guarantees that I'll then pull it. Btw, I liked the do_lookup cleanups, but nicer commit logs would have been good. Especially the first lines. The whole untangling do_lookup(), part 1 untangling do_lookup(), part 2 untangling do_lookup(), part 3 untangling do_lookup(), part 4 untangling do_lookup(), part 5 untangling do_lookup(), part 6 untangling do_lookup(), part 7 untangling do_lookup(), part 8 untangling do_lookup(), part 9 in shortlogs (and gitk!) does turn me off. So since you have to redo the series anyway, can I ask you to perhaps try to make it a bit more descriptive? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html