On Mon, Mar 26, 2012 at 12:54:23PM +0200, Miklos Szeredi wrote: > This also eliminates the weird retry loop, that could, in theory, retry the > cached lookup any number of times (very unlikely scenario: needs two parallel > do_lookups and d_revalidate always returning zero). That really needs to be carved into much smaller pieces - the sucker is convoluted as hell and there's a lot of codepaths in there with nearly zero test coverage. I've split it up into provably equivalent transformations, leading more or less to the state where yours ends up. I _think_ I've reconstructed the sequence of changes more or less close to what you were doing there, but the next time you have to do something of that kind, do not collapse that into a single patch. It's really easier to review step by step... Anyway, I'd put the whole thing into vfs.git#for-linus; see if you have any problems with it. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
