Re: [PATCH 03/25] vfs: split __dentry_open()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 26, 2012 at 03:22:09PM +0200, Miklos Szeredi wrote:
> > I think the O_DIRECT checks should move out of the VFS. ??The direct I/O
> > method isn't called from the VFS anywhere, but just from the
> > generic_file_* routines in filemap.c, which suggest doing the O_DIRECT
> > check in there as well.
> 
> Returning the error at the earliest opportunity (from open as opposed
> to read/write) makes sense.  Given that some apps may actually rely on
> the return value from open to verify O_DIRECT support, it doesn't seem
> to be a good idea to move the checks to read/write.

I'm fine with keeping it in open, bu it should be in generic_file_open,
not in the VFS (and yeah, generic_file_open is in open.c not filemap.c
where it should be, sorry)

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux