On Wed, Mar 07, 2012 at 10:22:38PM +0100, Miklos Szeredi wrote: > From: Miklos Szeredi <mszeredi@xxxxxxx> > > GFS2 doesn't open the file in ->create, but it does check the LOOKUP_EXCL flag > in it's create function. Convert to using ->atomic_create and checking O_EXCL > so that the nameidata argument is no longer necessary. It seems odd that we require implementing ->atomic_create even if we don't actually do an atomic create but just want to look at the flags. In fact I wonder if we really need to bother with having ->atomic_create and ->create, or if we should have one method (kinda contra my previous stance that ->atomic_open and ->atomic_create should be one). This method then could or could not return a file pointer, but it would always be the entry point for creates. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
