For removing the key scheme notion, is it correct to remove: UBIFS_KEY_MAX_LEN and UBIFS_SK_, UBIFS_S_KEY_BLOCK_BITS, ... and replace it with a fixed UBIFS_KEY_LEN (and other values), thus also ignoring key_fmt in key_max_inode_size and simply use a fixed key scheme? Or should I simply reduce MAX_LEN to 8 but still allow multiple bit assignments within those 8 bytes via selecting a different key_fmt. Cheers, Joel Reardon On Mon, 12 Mar 2012, Artem Bityutskiy wrote: > On Mon, 2012-03-12 at 15:30 +0200, Artem Bityutskiy wrote: > > > Btw, when I was > > > developing it I used the last 8 bytes from the key as the key position, > > > because the key was 16 bytes but only 8 were used. Could you comment on > > > the last 8 bytes of ubifs keys? > > > > I think you can use them. But is it possible to kill these things from > > the data nodes themselves? We can always find it by looking up the index > > by the data node key, right? > > Joel, but please, send small patches, preparation patches, etc. Do not > disappear for several months and do not come back with another big > patch. Tell about your intentions in advance. > > E.g., if you decide to start using those unused 8 bytes - first do small > preparations like removing the notion of "key scheme" which we > provisioned but never used (from comments as well). Clean-up the "space" > for yourself. Then start using them for your purposes. As I said, as > soon as I get the first patch I like, I'll create a separate branch in > the UBIFS git tree for your work. > > Thanks! > > -- > Best Regards, > Artem Bityutskiy > > -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html