On 03/07/2012 07:00 PM, Boaz Harrosh wrote: > On 03/07/2012 06:18 PM, Darrick J. Wong wrote: >> On Wed, Mar 07, 2012 at 04:05:10PM -0800, Darrick J. Wong wrote: <snip> >> diff --git a/block/blk-integrity.c b/block/blk-integrity.c >> index da2a818..f2d51f9 100644 >> --- a/block/blk-integrity.c >> +++ b/block/blk-integrity.c >> @@ -420,6 +420,10 @@ int blk_integrity_register(struct gendisk *disk, struct blk_integrity *template) >> } else >> bi->name = bi_unsupported_name; >> >> +#ifdef CONFIG_BLK_DEV_INTEGRITY > > Ooof I feel like a mute. > > No also iscsi data digest needs stable pages. Please remove any reference to > CONFIG_BLK_DEV_INTEGRITY. It needs to be supported for other > transport needs. > Just make the default off. (Which it is) > > I'll check to see how to add this for iscsi, when data digest is on > > Thanks > Boaz > >> + disk->queue->backing_dev_info.state |= (1 << BDI_stable_writes); Actually I will have an hard time accessing the BDI from the iscsi LLD Can you please put this flag as part of the topology parameters exported from a request_queue. And inspect it from there. It should be a block device property. not a BDI one. Thanks Boaz >> +#endif >> + >> return 0; >> } >> EXPORT_SYMBOL(blk_integrity_register); <snip> -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
