> On Wed, Feb 15, 2012 at 11:37:13PM +0100, Kai Bankett wrote:
>> rootdir = (struct qnx4_inode_entry *) (bh->b_data + i *
>> QNX4_DIR_ENTRY_SIZE);
>> - if (rootdir->di_fname != NULL) {
>> + if (!rootdir->di_fname) {
>
> Huh???
> a) this actually inverts the test
> b) ->di_fname is actually an array; the test made no
> sense even before that change; it's _never_ NULL. See commit
> 1aab323ea5cd67d2d2572a1f2794978583ff8545 in -rc1...
>
Ack.
Never, ever again do even small, quick style fixes after testing.
(that's what I've learned from it ...)
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
