On Wed, Feb 15, 2012 at 11:16 AM, Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote: > On Tue, Feb 14, 2012 at 05:46:24PM -0800, Andi Kleen wrote: >> Alexey Dobriyan <adobriyan@xxxxxxxxx> writes: >> >> > 1) consistently use "unsigned int" for dentry name length, >> > 2) reuse subtraction result for return value, exact value doesn't matter >> > because function is only used in boolean context, >> > 3) use *p++ idiom for even better code. >> >> I'm sure there are even better ways to do the comparision using longer >> words, especially as we know the boundaries and alignment. > > This requires terminating dentry names with 1-3 NULs. > Al, can we afford such beauty? Hmm. At least, in link_path_walk(), there is no room to insert NULs. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
