On Mon, Feb 06, 2012 at 12:49:43PM -0500, Christoph Hellwig wrote: > On Mon, Feb 06, 2012 at 05:45:49PM +0000, Matthew Garrett wrote: > > On Mon, Feb 06, 2012 at 12:35:53PM -0500, Christoph Hellwig wrote: > > > +#define HFSPLUS_IOC_BLESS _IO('f', 0x20) > > > > > > I'd probably move this to fs.h and follow the numbering there, > > > otherwise we are bound to run into conflicts. > > > > Ok. Any problem with leaving something filesystem specific in there? > > Leaving it in hfsplus sounds fine, but I'd avoid using 'f' then just to > reduce the chance for overlap. Using the same range but putting it in a different file seems like a good way to have someone miss it. I added the range to ioctl-list.txt so in theory nobody should step on it - do you think that's likely to be inadequate? -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html