On Mon, 2012-02-06 at 13:56 +0000, Al Viro wrote: > On Mon, Feb 06, 2012 at 10:50:44AM +0200, Artem Bityutskiy wrote: > > > WRT 'sen_nlink()' - I can use it instead of 'drop_nlink()'/'inc_nlink()' > > of course. But I do not really see why is this better. E.g., > > 'drop_nlink()' additionally gives me ' WARN_ON()' in case of 'i_nlink' > > wrapping. > > So does inc_nlink() when you are asking to get from nlink=0 to nlink=1. > I.e. on failure exit in your unlink()... Indeed! I'll switch to 'clear_nlink(inode)' and 'set_nlink(inode, 1)' for those inodes which are being unliked. -- Best Regards, Artem Bityutskiy
Attachment:
signature.asc
Description: This is a digitally signed message part
