After digging through Lucian comments here are my incremental fixes to address them. This code is also available at: kernel.org/pub/scm/linux/kernel/git/ebiederm/sysctl.git Eric W. Biederman (4): sysctl: An easier to read version of find_subdir sysctl: Correct error return from get_subdir sysctl: Comments to make the code clearer. sysctl: Don't call sysctl_follow_link unless we are a link. fs/proc/proc_sysctl.c | 51 +++++++++++++++++++++++++++++++++--------------- 1 files changed, 35 insertions(+), 16 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html