On Tue, Jan 31, 2012 at 7:13 AM, Eduardo Otubo <otubo@xxxxxxxxxxxxxxxxxx> wrote: > On Sat, Jan 28, 2012 at 04:11:54PM -0600, Will Drewry wrote: >> [This patch depends on luto@xxxxxxx's no_new_privs patch: >> https://lkml.org/lkml/2012/1/12/446 >> ] > > Will, > > I know you clearly pointed to use luto@xxxxxxx's first no_new_privs > patch, but I couldn't avoid to test it with the latest (and 3rd) version > of the patch [0]. Which defines PR_GET_NO_NEW_PRIVS as 37 as you can see > here [1]. The compilation then would break here: > > CC kernel/sys.o > kernel/sys.c: In function ‘sys_prctl’: > kernel/sys.c:1975: error: duplicate case value > kernel/sys.c:1904: error: previously used here > make[1]: *** [kernel/sys.o] Error 1 > make: *** [kernel] Error 2 > > I just changed the value of PR_ATTACH_SECCOMP_FILTER to 38 and > everything went fine. Do you see any problems on changing this value? Should be fine -- in the next version, I won't be adding a new PR_ define at all. Feel free to change it to whatever compiles -- the code only uses the define name for access. Sorry for the collision - I posted the last rev without the latest from luto. Cheers! will > Regards, > > [0] - https://git.kernel.org/?p=linux/kernel/git/luto/linux.git;a=heads > [1] - > https://git.kernel.org/?p=linux/kernel/git/luto/linux.git;a=blobdiff;f=include/linux/prctl.h;h=a6b5ac9cfe560eeb277646fbe338ae2b14c46caf;hp=7ddc7f1b480fd41318d94c0a39c8e2ff80f9c5f8;hb=7102b0e278af50d27b5d61d1be5faaba1b0a091e;hpb=acb42a3b611d7ad4cb173c3b37674b549df2ffeb > > -- > Eduardo Otubo > Software Engineer > Linux Technology Center > IBM Systems & Technology Group > Mobile: +55 19 8135 0885 > eotubo@xxxxxxxxxxxxxxxxxx > -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
