Re: [PATCH 4/4] Allow unprivileged chroot when safe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 15, 2012 at 04:37:21PM -0800, Andy Lutomirski wrote:

> +	is_chrooted = (fs->root.mnt->mnt_mountpoint !=
> +		       fs->root.mnt->mnt_parent->mnt_root ||
> +		       fs->root.dentry != fs->root.mnt->mnt_root);

Folks, is it _that_ hard to at least try to compile your patches?  Hint:
this one will *not*.  That sad detail aside, this test would have been
a pile of garbage even on the kernels that used to have mnt_mountpoint
in struct vfsmount.  What *are* you trying to test here?  The last part
at least does make some sense - it's "process root happens to be the
root of some vfsmount".  The first part, though, makes no sense whatsoever;
it's "... and that vfsmount is mounted on top of root of some other
vfsmount".

Grr...  NAKed, with extreme prejudice.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux