On Mon, Dec 26, 2011 at 10:37:56AM -0800, Linus Torvalds wrote: > > I'm committing the appended version instead. It removes all the games with > IS_ERR(), and just does the checking at the allocation point, the way the > other lease_alloc() user does too. > > Holler if you see something odd in there.. Looks fine to me. > @@ -1284,8 +1280,7 @@ restart: > > out: > unlock_flocks(); > - if (!IS_ERR(new_fl)) > - locks_free_lock(new_fl); > + locks_free_lock(new_fl); > return error; > } > (And, oops, I missed that last check--thanks for catching it.) --b. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html