On Wed, Dec 14, 2011 at 10:48 PM, Ingo Molnar <mingo@xxxxxxx> wrote: > * Kees Cook <keescook@xxxxxxxxxxxx> wrote: > >> + ab = audit_log_start(current->audit_context, >> + GFP_ATOMIC, AUDIT_AVC); > > Hm, is GFP_ATOMIC really necessary here? Why not GFP_KERNEL? > This is in VFS process context, not in some atomic context that > has to be careful about allocations, right? Hm, that's true. I had started from the lsm_audit interface, but had to expand it, and in the process copied its use of audit_log_start(). But yeah, I don't see a reason it can't be GFP_KERNEL. I'll adjust it. Thanks! -Kees -- Kees Cook ChromeOS Security -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
