On Tue, 2011-11-22 at 13:21 +0100, Jan Kara wrote: > > + __get_cpu_var(bdp_ratelimits)++; > I think you need preempt_disable() and preempt_enable() pair around > __get_cpu_var(). Otherwise a process could get rescheduled in the middle of > read-modify-write cycle... there's of course the this_cpu_inc(bdp_ratelimits); thing. On x86 that'll turn into a single insn, on others it will add the required preempt_disable/enable bits. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html